Fix setup-hooks.sh: jq syntax error and preserve existing hooks#4
Open
croakingtoad wants to merge 1 commit intoKyleAMathews:mainfrom
Open
Fix setup-hooks.sh: jq syntax error and preserve existing hooks#4croakingtoad wants to merge 1 commit intoKyleAMathews:mainfrom
croakingtoad wants to merge 1 commit intoKyleAMathews:mainfrom
Conversation
This commit fixes two issues in the setup script: 1. **Fix jq syntax error**: Renamed the jq variable from `$end` to `$sessionend` because `end` is a reserved keyword in jq, causing the error: "syntax error, unexpected end, expecting IDENT" 2. **Preserve existing hooks**: Changed the script to append new hooks to existing hook arrays instead of replacing them entirely. This prevents the setup from deleting users' existing hook configurations. Before: `.hooks.UserPromptSubmit = [...]` (overwrites) After: `.hooks.UserPromptSubmit = (.hooks.UserPromptSubmit // []) + [...]` (appends) These changes allow the setup to work correctly on systems with existing Claude Code hook configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two critical issues in the
setup-hooks.shscript that prevented successful installation:1. Fix jq syntax error
Problem: The script failed with the error:
Cause: The variable name
$endconflicts with jq's reserved keywordend(used to terminate structures).Solution: Renamed the jq variable from
$endto$sessionend.2. Preserve existing hooks
Problem: The setup script completely overwrote the
.hooksconfiguration in~/.claude/settings.json, deleting any existing hooks users had configured.Solution: Changed the script to append new hooks to existing arrays instead of replacing them entirely.
Before:
This overwrites any existing UserPromptSubmit hooks.
After:
This appends to existing hooks, preserving user configuration.
Testing
Tested on a system with existing Claude Code hooks:
Impact
These changes allow the setup to work correctly on systems with existing Claude Code hook configurations, which is likely the common case for users installing claude-code-ui.