Convert ValidateReadsetFilesAction and ImportReferenceSequencesAction to use FileLike#350
Convert ValidateReadsetFilesAction and ImportReferenceSequencesAction to use FileLike#350labkey-bpatel merged 6 commits intodevelopfrom
Conversation
| @@ -434,8 +435,21 @@ public static class DownloadTempImageAction extends ExportAction<TempImageAction | |||
| @Override | |||
| public void export(TempImageAction form, HttpServletResponse response, BindException errors) throws Exception | |||
There was a problem hiding this comment.
@bbimber - Can you please provide a usage scenario for this action. Thanks!
There was a problem hiding this comment.
are you asking for a way to test it?
There was a problem hiding this comment.
So I believe both DownloadTempImageAction and ConvertTextToFileAction are really old code that I dont see used anywhere. Rather than refactor them, those classes and the associated form classes could be removed. Let me know if you want to do this or have me do it.
There was a problem hiding this comment.
Well was wondering how that action gets called and how the values for directory and filename gets set.
But sounds good, if they are not being used, then I can remove them as part of this PR.
…sociated form classes.
labkey-bpatel
changed the title
| for (String fn : form.getFileNames()) | ||
| { | ||
| File f = new File(baseDir, fn); | ||
| File f = FileSystemLike.toFile(baseDir.resolveChild(fn)); |
There was a problem hiding this comment.
No need to convert back to File here. FileLike.exists() should work
There was a problem hiding this comment.
nevermind I see that this gets passed to the job. That's a future story.
Merge discvr-25.3 to discvr-25.7
3 participants
Rationale
Secure controller action/API endpoints that might allow unauthorized access to the files on the server by using FileLike instead of File (String, String) pattern.
Related Pull Requests
Changes