Improve failure logging from DbScope.TransactionTestCase

[labkey-tchad]

Rationale

The error message for DbScope.TransactionTestCase.testServerRowLock isn't as informative as it could be. If we throw the unexpected exception instead of just logging the message, it will help diagnose what went wrong.

  java.lang.AssertionError: Unexpected exceptions: null
java.lang.IllegalStateException: Caller is already loading this object!
  at org.junit.Assert.fail(Assert.java:89)
  at org.junit.Assert.assertTrue(Assert.java:42)
  at org.labkey.api.data.DbScope$TransactionTestCase.testServerRowLock(DbScope.java:3399)

Related Pull Requests

• N/A

Changes

• Improve failure logging from DbScope.TransactionTestCase

[labkey-jeckels]

Failure mode looks more helpful. One request before merging though.

[labkey-jeckels]

A comment on the intent here would be helpful - I believe it's choosing between reusing an existing exception in the list or throwing a new one?

[labkey-jeckels]

@labkey-tchad I pushed a change to this FB to make it a best-effort attempt to log the lock and activity data. See what you think before merging.