-
Notifications
You must be signed in to change notification settings - Fork 7
Provide warnings for unknown fields for cross sample type import #7370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cnathe
wants to merge
14
commits into
develop
Choose a base branch
from
fb_crossSampleTypeWarnings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to get distinct values for based on the data file contents
Contributor
Author
|
@labkey-klum could you do CR on this PR to look at the changes made to the InferDomainAction for getting the distinctValues for column keys? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
For awhile now, we have shown warnings about file import / update column headers above the file preview grid. For single sample type and single source type file imports, we show warnings about unknown fields, system fields, sample/aliquot only fields, etc. This PR does the same type of warnings check for fields in the cross sample type import case.
It also updates the display of some error messages on the source and sample file import case to use bold instead of single quotes to highlight the value / field in the error message.
Related Pull Requests
Changes