Rlabkey test for makeFilter #2857
Merged
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
requested changes
Jan 26, 2026
data/api/rlabkey-api-query.xml
Outdated
| </response> | ||
| </test> | ||
| <!-- | ||
| Uncomment when Rlabkey 3.4.5 is available |
Contributor
There was a problem hiding this comment.
The tests on TeamCity should run with the latest code in the package, so you should be able to uncomment this new test case now.
Contributor
There was a problem hiding this comment.
nevermind. I didn't see the comment from the other PR until now.
Contributor
Author
There was a problem hiding this comment.
No you are right, the tests will build and install what is in the repo (not CRAN). So I don't need to wait for the publish. It does mean that this may fail locally for some devs but I don't think that is a concern.
cnathe
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Automated tests for LabKey filter generation for both legacy and future formats.