The UltraVNC support has been fixed. If the authScheme of rfbUltra(17…#667
Open
yansong1221 wants to merge 1 commit intoLibVNC:masterfrom
Open
The UltraVNC support has been fixed. If the authScheme of rfbUltra(17…#667yansong1221 wants to merge 1 commit intoLibVNC:masterfrom
yansong1221 wants to merge 1 commit intoLibVNC:masterfrom
Conversation
…) is not processed, the UltraServer will not recognize the client as an UltraViewer, resulting in the TextChat function being unusable
|
@yansong1221: Thanks for your work! Please edit your description, it is an "UltraVNC Viewer" ^^ Have you tested with the current latest UltraVNC version? |
Author
|
Yes, when I tested the TextChat function, I found that the UltraVNC prompt was not supported, and then I modified it according to the UltraVNC source code. |
Member
|
@yansong1221 thanks for the contribution! Please rework your PR to make less architectural changes, i.e. don't introduce another function if not really needed. Where is rfbVncAuthContinue in the protocol spec? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…) is not processed, the UltraServer will not recognize the client as an UltraViewer, resulting in the TextChat function being unusable