Open
Conversation
josevalim
reviewed
Oct 28, 2025
Contributor
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Looks great to me! Just some minor nitpicks on the UI bits :)
| prompt: [key: "Choose a source"] | ||
| ) %> | ||
| <small id="source_id" class="form-text text-muted">This source will use this backend as its default ingest destination. Only sources with default ingest backend support enabled are shown.</small> | ||
| <div :if={length(@available_sources || []) > 0}> |
Contributor
There was a problem hiding this comment.
Suggested change
| <div :if={length(@available_sources || []) > 0}> | |
| <div :if={@available_sources != []}> |
| </.button> | ||
| </li> | ||
| </ul> | ||
| <p :if={Enum.empty?(@backend.sources || [])}>No sources configured yet</p> |
Contributor
There was a problem hiding this comment.
It seems this is a pattern from before this pull request, but it would be great to remove the conditionals such as || [], by making sure they are always initialized to a list.
| <i class="fas fa-info-circle"></i> | ||
| <strong>Ingest from all sources:</strong> This backend is configured to receive logs from ALL your sources automatically. | ||
| To limit this backend to specific sources, disable the "Ingest from all sources" option in the backend settings. | ||
| </div> |
Contributor
There was a problem hiding this comment.
I am not sure if you folks decide the UI but I wonder if you should move the toggle here, so someone who wants to manage sources does not need to go to another page, then come back here, to control them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ANL-1138
if backends.default_ingest=true → ingest all sources to default backend ( BigQuery) and all backends with this true flag
if backends.default_ingest=false + source_backends record → ingest only for that Source to default backend (BigQuery) and that specified backend
Added a pill indicator for default ingestion.
Also removed the source backend list from sources page, as that is no longer relevant.
this greatly simplifies the ingestion model.
the old source column is left in as per non-destructive migration policy. will be removed when we eventually do a v2.