feat: team owner can create private:admin access token#3039
Open
msmithstubbs wants to merge 1 commit intoLogflare:mainfrom
Open
feat: team owner can create private:admin access token#3039msmithstubbs wants to merge 1 commit intoLogflare:mainfrom
msmithstubbs wants to merge 1 commit intoLogflare:mainfrom
Conversation
msmithstubbs
force-pushed
the
ui/create-admin-token
branch
2 times, most recently
from
7049aa6 to
b37a048
Compare
Ziinc
approved these changes
Dec 17, 2025
lib/logflare/teams/team_context.ex
Outdated
| def parse_team_id(_), do: {:error, :invalid_team_id} | ||
|
|
||
| def team_owner?(%__MODULE__{team: team, user: user, team_user: nil}), | ||
| do: team_owner?(team, user.email) |
Contributor
There was a problem hiding this comment.
can we collocate the functions for better readability please
lib/logflare/teams/team_context.ex
Outdated
|
|
||
| def parse_team_id(_), do: {:error, :invalid_team_id} | ||
|
|
||
| def team_owner?(%__MODULE__{team: team, user: user, team_user: nil}), |
msmithstubbs
force-pushed
the
ui/create-admin-token
branch
from
b37a048 to
bb3f3af
Compare
msmithstubbs
force-pushed
the
ui/create-admin-token
branch
from
bb3f3af to
a3cbe33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI to allow team owner can create a
private:adminaccess token.This PR is the UI only. Access control for this token will be a subsequent PR.
Part of ANL-1251