Skip to content

Fix and optimize TDMS_TimeSecond #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mizmar wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix and optimize TDMS_TimeSecond #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e98c63
fix: TDMS_TimeSecond docs and off-by-one day error in base year
mizmar Feb 10, 2026
85adb1d
optimize TDMS_TimeSecond full years
mizmar Feb 10, 2026
c497e56
Fix TDMS_SaveDataLittleEndian64
mizmar Feb 12, 2026
93b816a
Use endian-agnostic serialization, remove endian config
mizmar Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions config/TDMS_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,6 @@ extern "C" {
#define TDMS_CONFIG_MAX_GROUP_OF_FILE 4
#define TDMS_CONFIG_MAX_CHANNEL_OF_GROUP 8

/**
* @brief Determines system Endianness
* - 0: little-endian
* - 1: big-endian
*/
#define TDMS_CONFIG_SYSTEM_ENDIANNESS 0



#ifdef __cplusplus
}
Expand Down
46 changes: 8 additions & 38 deletions src/TDMS.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
/**
* @brief Specify the number of days in the month
* daysPerMonth[0][]: non leap year
* daysPerMonth[0][]: leap year
* daysPerMonth[1][]: leap year
*/
const int8_t
daysPerMonth[2][13] = {{-1, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31},
Expand Down Expand Up @@ -147,8 +147,8 @@ const uint8_t dataTypeLength[TDMS_DataType_MAX] =
/**
* @brief Calculate number of days between LabVIEW Timestamp base and inserted
* date
* @param Day: Day number (0 to 31)
* @param Month: Month number (0 to 12)
* @param Day: Day number (1 to 31)
* @param Month: Month number (1 to 12)
* @param Year: Year number (1904 to ...)
* @retval Number of days
*/
Expand All @@ -168,7 +168,7 @@ TDMS_DateDef(uint8_t Day, uint8_t Month, uint16_t Year)
for (m = Month; m >= 1; m--)
{
if (m == Month)
total_days += Day;
total_days += Day - 1;
else
total_days += daysPerMonth[leapYear(y)][m];
}
Expand All @@ -177,18 +177,12 @@ TDMS_DateDef(uint8_t Day, uint8_t Month, uint16_t Year)
{
for (m = 12; m >= BaseMonth; m--)
{
if (m == BaseMonth)
total_days += daysPerMonth[leapYear(y)][m] - BaseDay;
else
total_days += daysPerMonth[leapYear(y)][m];
total_days += daysPerMonth[leapYear(y)][m];
}
}
else
{
for (m = 12; m >= 1; m--)
{
total_days += daysPerMonth[leapYear(y)][m];
}
total_days += leapYear(y) ? 366 : 365;
}
}

Expand Down Expand Up @@ -252,21 +246,9 @@ TDMS_GenerateChannelPath(TDMS_Group_t *Group,
static uint8_t
TDMS_SaveDataLittleEndian32(uint8_t *data, uint32_t value)
{
typedef union
{
uint32_t Uint32Value;
uint8_t Uint8Value[4];
} U32toU8_t;

U32toU8_t Buffer = {.Uint32Value = value,};

for (uint8_t i = 0; i < 4; i++)
{
#if (TDMS_CONFIG_SYSTEM_ENDIANNESS == 0)
data[i] = Buffer.Uint8Value[i];
#else
data[i] = Buffer.Uint8Value[4-i];
#endif
data[i] = value >> (8*i);
}

return 4;
Expand All @@ -282,21 +264,9 @@ TDMS_SaveDataLittleEndian32(uint8_t *data, uint32_t value)
static uint8_t
TDMS_SaveDataLittleEndian64(uint8_t *data, uint64_t value)
{
typedef union
{
uint32_t Uint64Value;
uint8_t Uint8Value[8];
} U64toU8_t;

U64toU8_t Buffer = {.Uint64Value = value,};

for (uint8_t i = 0; i < 8; i++)
{
#if (TDMS_CONFIG_SYSTEM_ENDIANNESS == 0)
data[i] = Buffer.Uint8Value[i];
#else
data[i] = Buffer.Uint8Value[8-i];
#endif
data[i] = value >> (8*i);
}

return 8;
Expand Down
4 changes: 0 additions & 4 deletions src/include/TDMS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ extern "C" {
#define TDMS_CONFIG_MAX_CHANNEL_OF_GROUP 8
#endif

#ifndef TDMS_CONFIG_SYSTEM_ENDIANNESS
#define TDMS_CONFIG_SYSTEM_ENDIANNESS 0
#endif


/* Exported Data Types ----------------------------------------------------------*/

Expand Down