Add commented out block to simplify setting default temperature display unit#174
Closed
matt-sorenson wants to merge 1 commit intoMallocArray:mainfrom
matt-sorenson:example_override_display_to_c
Closed
Add commented out block to simplify setting default temperature display unit#174matt-sorenson wants to merge 1 commit intoMallocArray:mainfrom matt-sorenson:example_override_display_to_c
matt-sorenson wants to merge 1 commit intoMallocArray:mainfrom
matt-sorenson:example_override_display_to_c
Conversation
Owner
|
You don't necessarily need to use So I think this is extra noise in the main configuration file to add extra commented out information, when there are other methods to accomplish the same goal that are built in. I wouldn't be opposed to a separate page or maybe a part of the configuration.md that could list some specific examples of things like extend blocks as users find them helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had this thought when I saw #131
I feel like when I was first learning esphome this type of config was hard as I wasn't familiar with using
extend. I think some common example configs that the user may want to override could be helpful for on-boarding new users and for existing users it still simplifies it if they want to change a default that a decent number of users will want changed.Even if #131 is merged in the opposite version of this PR with it set to
RESTORE_DEFAULT_ONwould be good.