Open
Conversation
…/python-api-client into independent_test_runs
Added note that TEST_ related variables are optional
Pull Request Test Coverage Report for Build 22061374321Details
💛 - Coveralls |
varmar05
reviewed
Feb 19, 2026
| json_headers = {"Content-Type": "application/json"} | ||
|
|
||
|
|
||
| def get_default_overrides(): |
Contributor
There was a problem hiding this comment.
seems more like a constant
| return {"storage": storage, "projects": 2, "api_allowed": True} | ||
|
|
||
|
|
||
| def teardown(mc: MerginClient, client_workspace_id): |
Contributor
There was a problem hiding this comment.
add some docstring so it is clear what this teardown is supposed to do (e.g. I would expect user delete with such name)
| else: # if user is not provided we create one | ||
| # user emial is generated with random | ||
| user = f"apitest_{create_random_suffix()}@example.com" | ||
| password = "testpass123" |
Contributor
There was a problem hiding this comment.
maybe we should keep PWD secret or randomly generated
| break | ||
| client_workspace_id = client_workspace["id"] | ||
| client_workspace_storage = client_workspace["storage"] | ||
| def mc2(): |
Contributor
There was a problem hiding this comment.
This seems pretty much the same as mc(), can we reuse it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made test independent createting new user and workspace everytime they run and deleting them afterwards
#272