This repository was archived by the owner on Feb 27, 2020. It is now read-only.
Open
Conversation
Contributor
Author
|
@johadalin @AlexHockey FYI... Not clear whether we should be looking to merge at this time -- just wanted to see if it solved the Kubernetes issue... |
Contributor
|
Does this cause Bono to do DNS lookups using the |
Contributor
Author
|
I don't fully understand the code, but from trace on a node with this patch... I think that's what we want? |
Contributor
Author
|
@AlexHockey ^^ |
Contributor
|
Yep, looks good to me. |
Contributor
|
Should this be merged down? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTs run and tested in Kubernetes deployment. Don't think I understand the implications or the background to why we use connection pooling in Bono well enough to know if this is the right thing to do though.
We'd also have to retire the BonoConnectedSprouts table from the MIB if we were to merge this.