Skip to content

Conversation

@noramibu
Copy link
Contributor

@noramibu noramibu commented Jan 27, 2026

Type of change

  • Bug fix
  • New feature

Description

I extended the age filter check to include all entities with baby variants. The filter was only checking AnimalEntit and ignoring other entities that have baby variants (such as villagers, hoglin, zoglin, piglin villager and zombie variants)

Also splitted age filter options for passive & aggressive mobs (user would like to kill baby zombies but ignore baby animals).

Related issues

closes #6088

How Has This Been Tested?

Tested in singleplayer, works fine

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Nippaku-Zanmu
Copy link

I think judging based on specific monster names lacks robustness.

If Minecraft introduces a new monster, this would require modifications, which is not convenient for Meteor to adapt to new versions.

@noramibu
Copy link
Contributor Author

I think judging based on specific monster names lacks robustness.

If Minecraft introduces a new monster, this would require modifications, which is not convenient for Meteor to adapt to new versions.

I don't see a better way to do this without adding complexity or without reflections. If you have an idea, PR it and i will close this one ^^

@Nippaku-Zanmu
Copy link

Nippaku-Zanmu commented Jan 28, 2026

I think judging based on specific monster names lacks robustness.
If Minecraft introduces a new monster, this would require modifications, which is not convenient for Meteor to adapt to new versions.

I don't see a better way to do this without adding complexity or without reflections. If you have an idea, PR it and i will close this one ^^

Why not just consider all creatures that aren't animals as monsters?
I don’t remember any entities in Minecraft that are neither monsters nor animals and also have juvenile variants.
And it’s unlikely that this will be added in the future.

@noramibu
Copy link
Contributor Author

I think judging based on specific monster names lacks robustness.
If Minecraft introduces a new monster, this would require modifications, which is not convenient for Meteor to adapt to new versions.

I don't see a better way to do this without adding complexity or without reflections. If you have an idea, PR it and i will close this one ^^

Why not just consider all creatures that aren't animals as monsters?
I don’t remember any entities in Minecraft that are neither monsters nor animals and also have juvenile variants.
And it’s unlikely that this will be added in the future.

Sorry, i didn't get what you meant. Some entities doesn't have baby forms such as skeletons or creepers, so I don't get what you mean with variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

killaura incorrect baby filter

2 participants