Move Flux Reweighter and Flux Systematics to MAT-MINERvA#11
Open
bamesserly wants to merge 1 commit intomainfrom
Open
Move Flux Reweighter and Flux Systematics to MAT-MINERvA#11bamesserly wants to merge 1 commit intomainfrom
bamesserly wants to merge 1 commit intomainfrom
Conversation
The only substantive use FRW was used in are the HistWrappers. This behavioris going to need to be readded in MAT-MINERvA if we want it. I believe there was nothing stopping FluxSystematics from going to MAT-MINERvA yesterday. Also modified the dict's and build's CMakeLists. Don't know what I was doing with that, but it worked.
Collaborator
Author
|
Also: there are still several references to FluxReweighter in the macros and scripts folders. Those should be cleaned out and/or moved to MAT-MINERvA when this goes through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue #10. Our flux stuff has no business in the MAT. It's currently holding up potential adoption by an external user. Where the rubber hits the road: HistWrappers require MAT-MINERvA 👎.
Flux Systematics can move over, trivially, I believe. This technically isn't a dependence issue, but it's related to FRW, so moving it now.
FluxReweighter, OTOH has a complicated use inside of HistWrapper construction. In my first commit on this branch, I've removed the complicated use and removed FRW and FluxSysts. Also modified the dict's and build's CMakeLists. Don't know what I was doing with all that, but it worked. MAT compiles. I also, trivially, move FRW and FluxSysts into MAT-MINERvA and that compiled as well. I'll link the PR when I make it.
For MAT's purposes, nothing else needs to be done. Though plumbing experts should make sure the dict and cmake stuff is all good.
BUT this also needs to wait on a merge until we've sorted out the solution in concert on the MAT-MINERvA end.