Fix: Resolve mobile redirect double-encoding issue in Safari/iOS (#66…#704
Open
Ariz253 wants to merge 1 commit intoMrSwitch:mainfrom
Open
Fix: Resolve mobile redirect double-encoding issue in Safari/iOS (#66…#704Ariz253 wants to merge 1 commit intoMrSwitch:mainfrom
Ariz253 wants to merge 1 commit intoMrSwitch:mainfrom
Conversation
…witch#661); Includes line-ending style fixes
Author
|
Any updates? |
Owner
|
@Ariz253 you need to update the /src folder rather than the /dist folder please, sorry it is a little confusing I need to sort that out. |
MrSwitch
force-pushed
the
master
branch
3 times, most recently
from
dc9b406 to
f6f63dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #661
This PR addresses Issue #661 by removing the redundant second layer of encodeURIComponent() inside the hello.utils.popup function (around line 1032).
Problem: The original double-encoding was an outdated workaround that now conflicts with the decoding behavior of modern iOS Safari/WebViews, causing the redirect to fail on devices like the iPhone 12 Pro Max.
Verification:
All 232 unit tests passed successfully.
Line-ending style errors were fixed via npm run lint -- --fix.
Manual desktop testing confirmed the demo page loads and all unit tests passed. I was unable to perform a live login test with a third-party provider. Therefore, I am requesting that the maintainers verify stability on both desktop browsers and the target iOS device.