Allow filtering by trigger bits, add accessor by michaelmackenzie · Pull Request #1670 · Mu2e/Offline

michaelmackenzie · 2025-12-10T21:46:17Z

No description provided.

FNALbuild · 2025-12-10T21:46:42Z

Hi @michaelmackenzie,
You have proposed changes to files in these packages:

Mu2eUtilities
Filters

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 1c80479: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild · 2025-12-10T22:01:05Z

☀️ The build tests passed at 1c80479.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged `1c80479` at `e391635`
build (prof)	✅	Log file. Build time: 04 min 47 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 2 files
clang-tidy	🔶	1 errors 7 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 1c80479 after being merged into the base branch at e391635.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

bechenard · 2026-01-06T00:45:33Z

Filters/src/TriggerResultsFilter_module.cc

+          Comment("Trigger line names to test; if any of these are set the event will pass the filter"), vector<string>()};
+        fhicl::Sequence<unsigned> triggerBits{ Name("TriggerBits"),
+          Comment("Trigger line bits to test; if any of these are set the event will pass the filter"), vector<unsigned>()};
      };


In the future, it would be nice if you could align the different fields, this makes the code easier to read

I tried to better align these

bechenard · 2026-01-06T00:50:20Z

Mu2eUtilities/inc/TriggerResultsNavigator.hh

+      throw cet::exception("TRIGGER") << "TriggerResultsNavigator: Bit " <<  bit << " not found";
+    }
+
    // Has ith path accepted the event?


Please avoid implementing functions in the header because any change can trigger massive recompilation (exception: simple accessor /setter). Could you implement this in the cc file?

I moved these to the cc file

bechenard · 2026-01-06T00:53:49Z

Mu2eUtilities/inc/TriggerResultsNavigator.hh

+      return accepted(name);
+    }

    bool      wasrun(std::string const& name) const;


I noticed that the trigger navigators relies a lot on strings, which is slow. IS there a way to improve this?

I added unordered maps so we can avoid more string comparisons. Users may ask about the bit, the string name, or the index, so all of these interfaces need to be maintained. I think this version should be clearer though.

michaelmackenzie · 2026-01-06T22:42:20Z

I updated the interface to be clearer, but this leads to downstream updates. Before it was ambiguous if an access was using/returning the bit or list index, now methods include this information in the function name.

michaelmackenzie · 2026-01-07T14:15:47Z

@FNALbuild run build test

FNALbuild · 2026-01-07T14:16:16Z

⌛ The following tests have been triggered for 2709cea: build (Build queue - API unavailable)

FNALbuild · 2026-01-07T14:39:10Z

☀️ The build tests passed at 2709cea.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged `2709cea` at `5d5efb9`
build (prof)	✅	Log file. Build time: 09 min 25 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	🔶	TODO (0) FIXME (1) in 6 files
clang-tidy	🔶	7 errors 578 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 2709cea after being merged into the base branch at 5d5efb9.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

brownd1978

Looks good to me

michaelmackenzie · 2026-01-24T16:22:20Z

I added an example fcl using this TriggerResultsFilter module, which also serves as an example of how to split a digi (or later processing stage) art file into Triggered and Triggerable given our recent update to merge these streams in Production. The splitting is actually trivial by using the output module SelectEvents option on the Digitize::TriggerResults object, so I added this as a comment in the fcl as well.

Is there anything else needed for this PR?

Allow filtering by trigger bits, add accessor

1c80479

michaelmackenzie requested a review from brownd1978 December 10, 2025 21:46

FNALbuild added build pending build running and removed build pending labels Dec 10, 2025

FNALbuild added build finished and removed build running labels Dec 10, 2025

oksuzian requested a review from bechenard December 18, 2025 00:34

bechenard requested changes Jan 6, 2026

View reviewed changes

Update trigger results navigator interface, reduce string comparisons

2709cea

FNALbuild added build pending and removed build finished labels Jan 6, 2026

FNALbuild added build running and removed build pending labels Jan 7, 2026

FNALbuild added build finished and removed build running labels Jan 7, 2026

brownd1978 approved these changes Jan 8, 2026

View reviewed changes

michaelmackenzie mentioned this pull request Jan 12, 2026

Follow trigger navigator changes Mu2e/EventNtuple#327

Open

Add example fcl to split Triggered and Triggerable

1d70d8b

FNALbuild added build pending and removed build finished labels Jan 24, 2026

Conversation

michaelmackenzie commented Dec 10, 2025

Uh oh!

FNALbuild commented Dec 10, 2025

Uh oh!

FNALbuild commented Dec 10, 2025

Uh oh!

bechenard Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

michaelmackenzie Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

bechenard Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

michaelmackenzie Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

bechenard Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

michaelmackenzie Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

michaelmackenzie commented Jan 6, 2026

Uh oh!

michaelmackenzie commented Jan 7, 2026

Uh oh!

FNALbuild commented Jan 7, 2026

Uh oh!

FNALbuild commented Jan 7, 2026

Uh oh!

brownd1978 left a comment

Choose a reason for hiding this comment

Uh oh!

michaelmackenzie commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants