Conversation
christopolise
requested changes
Nov 5, 2024
Contributor
christopolise
left a comment
There was a problem hiding this comment.
Looks great for the most part, however when I run
python3 main.py -vvv simulator I get an error saying that I needed to provide a value for simulated
Traceback (most recent call last):
File "/home/christopolise/dev/sss/main.py", line 104, in <module>
cli()
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
return self.main(*args, **kwargs)
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/home/christopolise/dev/sss/main.py", line 30, in run_simulator
simulator.run()
File "/home/christopolise/dev/sss/runners/simulator.py", line 366, in run
sim.start()
File "/home/christopolise/dev/sss/runners/simulator.py", line 310, in start
handle_input = controllers.start_inputs(self.system_q, self.input_q)
TypeError: start_inputs() missing 1 required positional argument: 'simulated'
When checking the help messages, I find no mention of changes of command line args for running things in a simulated environment, so maybe include some of those if we are changing the way we run things?
Member
|
@apal6981, can you rebase this PR so that the changes that were previously accepted don’t show up in this PR (physical_screen2.py, etc.)? |
… were breaking windows
Contributor
Author
|
I believe i have addressed the issues that needed to be addressed. I might have botched the rebase so somebody might want to look at that. I got a bit lost trying to do it on the commandline. |
2972705 to
06304e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was bothered that pygame was being imported by default. I changed that it only gets loaded when the screen is being simulated. The keyboard broadcaster was the culprit. I changed it that the keyboard is only checked when the virtual screen is being used. Also stuff from v2 merge so lets confirm and pull that one before this one.