Add __eq__ and __hash__ to Buffer, LaunchConfig, Kernel, ObjectCode #1534
+141
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make these classes hashable and comparable: - Buffer: identity based on (type, ptr, size) - LaunchConfig: uses _LAUNCH_CONFIG_ATTRS tuple for forward-compatible identity; also updates __repr__ to use the same attribute list - Kernel: identity based on (type, handle) - ObjectCode: identity based on (type, handle), triggers lazy load Stream, Event, Context, Device already had __eq__/__hash__.
Make these classes hashable and comparable: - Buffer: identity based on (ptr, size) - LaunchConfig: uses _LAUNCH_CONFIG_ATTRS tuple for forward-compatible identity; also updates __repr__ to use the same attribute list - Kernel: identity based on handle - ObjectCode: identity based on handle, triggers lazy load Remove type(self) from __hash__ in Event, Context, Buffer, LaunchConfig, Kernel, ObjectCode - CUDA handles are already unique, and removing type(self) maintains the hash/equality contract for subclasses. Add parameterized hash tests for all 8 core API classes. Stream, Device already had correct __eq__/__hash__ without type(self).
Andy-Jost
added
enhancement
Contributor
Contributor
Author
|
/ok to test e182f4c |
Andy-Jost
commented
Jan 25, 2026
Comment on lines
+25
to
+41
| def sample_device(init_cuda): | ||
| return Device() | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def sample_stream(sample_device): | ||
| return sample_device.create_stream() | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def sample_event(sample_device): | ||
| return sample_device.create_event() | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def sample_context(sample_device): | ||
| return sample_device.context |
Contributor
Author
There was a problem hiding this comment.
Once this change and the change adding __weakref__ members are both merged, I plan to revisit these fixtures (which overlap with test_weakref.py). There is an opportunity to rewrite and simplify test_hashable.py, test_comparable.py and test_weakref.py, possibly combining them.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complete hashability support for core API classes by adding
__eq__and__hash__to Buffer, LaunchConfig, Kernel, and ObjectCode.Changes
__eq__and__hash__to Buffer, LaunchConfig, Kernel, ObjectCodetype(self)from__hash__in Event, Context (and the new classes) - CUDA handles are already unique, and this maintains the hash/equality contract for subclasses_LAUNCH_CONFIG_ATTRStuple for forward-compatible identity in LaunchConfig__repr__in LaunchConfig to use the same attribute listIdentity basis:
(ptr, size)(grid, cluster, block, shmem_size, cooperative_launch)handlehandle(triggers lazy load)Stream, Event, Context, Device already had
__eq__/__hash__.Test Plan
test_hashable.pycover all 8 core classes