-
Notifications
You must be signed in to change notification settings - Fork 242
cuda.bindings.nvml: Small follow-on to #1524 #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR contains follow-on work to #1524 that was missed in the original implementation. The changes focus on: (1) adding the missed hand-written wrapper device_get_current_clock_freqs, (2) fixing length checks for structs with dynamically-sized fixed arrays, and (3) correcting return type signatures for several hand-written functions.
Changes:
- Added hand-written wrapper for
device_get_current_clock_freqswith proper string return type - Fixed array length validation in setters for
BridgeChipHierarchy,ClkMonStatus,ConfComputeGpuCertificate,ConfComputeGpuAttestationReport,NvlinkSupportedBwModes_v1, andGridLicensableFeaturesclasses - Corrected return type signatures for multiple functions and moved version initialization inside
nogilblocks for thread safety
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cuda_bindings/tests/nvml/test_device.py | Updated test to expect string return type instead of struct for device_get_current_clock_freqs |
| cuda_bindings/cuda/bindings/_nvml.pyx | Removed auto-generated DeviceCurrentClockFreqs_v1 class, added hand-written device_get_current_clock_freqs function, fixed array length checks in struct setters, corrected return type signatures, and moved version initialization inside nogil blocks |
| cuda_bindings/cuda/bindings/_nvml.pxd | Added typedef for DeviceCurrentClockFreqs_v1 and removed old function declaration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
|
/ok to test |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1537-to-12.9.x origin/12.9.x
cd .worktree/backport-1537-to-12.9.x
git switch --create backport-1537-to-12.9.x
git cherry-pick -x f4d32072396a240a962eaf3ae108abd0536e9acf |
|
This is a small set of follow-on work that was missed in #1524 (which added a bunch of hand-written wrappers to cuda.bindings.nvml).
device_get_current_clock_freqs