cuda.bindings.nvml: Use helper function for NVML struct versions #1541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a helper function to improve code readability when setting NVML struct versions. The change addresses issue #1535 by replacing repetitive bit-shifting operations with a clearer helper function.
Changes:
- Added
NVML_VERSION_STRUCThelper function to encapsulate the version encoding logic - Replaced all manual
sizeof(...) | (ver << 24)patterns with calls to the new helper function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
kkraus14
approved these changes
Jan 29, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535. See that bug for more details.
Basically, this adds a helper function to step in for the macro in
nvml.h(which can't be used from Cython as it's a macro). This just makes it a little more obvious what all of the shifting and or'ing is about.