Make cuda.bindings.nvml public #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the cuda.bindings.nvml module public by removing its underscore prefix (_nvml → nvml). The changes update import statements across test files, core modules, and internal bindings to reflect this new public API.
Changes:
- Updated all imports from
cuda.bindings._nvmltocuda.bindings.nvml - Renamed Cython module imports from
cy_nvmltocynvml - Updated copyright year to include 2026 across modified files
Reviewed changes
Copilot reviewed 21 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cuda_core/tests/system/test_system_device.py | Updated nvml import to use public API |
| cuda_core/cuda/core/system/exceptions.py | Updated nvml import and copyright year |
| cuda_core/cuda/core/system/_system_events.pyx | Updated nvml import and copyright year |
| cuda_core/cuda/core/system/_system.pyx | Updated nvml import and copyright year |
| cuda_core/cuda/core/system/_nvml_context.pyx | Updated nvml import and copyright year |
| cuda_core/cuda/core/system/_device.pyx | Updated nvml import to use public API |
| cuda_bindings/tests/nvml/util.py | Updated nvml import and copyright year |
| cuda_bindings/tests/nvml/test_pynvml.py | Updated nvml import and copyright year |
| cuda_bindings/tests/nvml/test_pci.py | Updated nvml import to use public API |
| cuda_bindings/tests/nvml/test_page_retirement.py | Updated nvml import and copyright year |
| cuda_bindings/tests/nvml/test_nvlink.py | Updated nvml import and copyright year |
| cuda_bindings/tests/nvml/test_init.py | Updated nvml import and copyright year |
| cuda_bindings/tests/nvml/test_gpu.py | Updated nvml import to use public API |
| cuda_bindings/tests/nvml/test_device.py | Updated nvml import to use public API |
| cuda_bindings/tests/nvml/test_cuda.py | Updated nvml import and copyright year |
| cuda_bindings/tests/nvml/test_compute_mode.py | Updated nvml import to use public API |
| cuda_bindings/tests/nvml/conftest.py | Updated nvml import and copyright year |
| cuda_bindings/cuda/bindings/cy_nvml.pyx | Updated internal Cython import from _nvml to nvml |
| cuda_bindings/cuda/bindings/_test_helpers/arch_check.py | Updated nvml import to use public API |
| cuda_bindings/cuda/bindings/_nvml.pxd | Renamed Cython import from cy_nvml to cynvml |
| cuda_bindings/cuda/bindings/_internal/_nvml.pxd | Renamed Cython import from cy_nvml to cynvml |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test |
rwgk
approved these changes
Jan 29, 2026
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Awesome!
ImportError can mask bugs. ModuleNotFoundError seems safer here?
Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com>
Contributor
Author
|
/ok to test |
Collaborator
|
It looks like every |
|
kkraus14
pushed a commit
that referenced
this pull request
Jan 30, 2026
mdboom
added a commit
to mdboom/cuda-python
that referenced
this pull request
Jan 30, 2026
* cuda.bindings.nvml: Small follow-on to NVIDIA#1524 * cuda.bindings.nvml: Make public * Fix NVML is compatible * Update cuda_core/cuda/core/system/_system.pyx Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com> --------- Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com>
kkraus14
added a commit
that referenced
this pull request
Jan 30, 2026
* Make cuda.bindings.nvml public (#1544) * cuda.bindings.nvml: Small follow-on to #1524 * cuda.bindings.nvml: Make public * Fix NVML is compatible * Update cuda_core/cuda/core/system/_system.pyx Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com> --------- Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com> * Update cuda_core/cuda/core/system/_system.pyx Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com> --------- Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com> Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all of the APIs vetted (at least from what they look like on the outside), I think we are ready to make this public. 🎉