Fix CI checks job to detect test failures #1547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checks job only verified if jobs were cancelled, but did not check if they failed. This allowed PRs to merge even when tests failed because the checks job would exit with 0 (success) when tests had result='failure'. Add failure checks alongside the existing cancellation checks for all test jobs and the doc job.
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
mdboom
approved these changes
Jan 30, 2026
This comment has been minimized.
This comment has been minimized.
cpcloud
reviewed
Jan 30, 2026
|
|
||
| checks: | ||
| name: Check job status | ||
| if: always() |
Contributor
There was a problem hiding this comment.
I can't remember if this necessary, but what about ${{ !failed() }} here to avoid the extra conditionals?
Collaborator
Author
There was a problem hiding this comment.
We need to block if the job is cancelled as well, so it can't just be !failed()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
checksjob to detect test failures, not just cancellationsresult == 'cancelled'but notresult == 'failure'Test plan