Skip to content

Use 'not success' checks instead of specific failure conditions #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwgk wants to merge 1 commit into from
+7 −7
Closed

Use 'not success' checks instead of specific failure conditions #1555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,16 +243,16 @@ jobs:
# Note: When [doc-only] is in PR title, test jobs are intentionally
# skipped and should not cause failure.
doc_only=${{ needs.should-skip.outputs.doc-only }}
if ${{ needs.doc.result == 'cancelled' || needs.doc.result == 'failure' }}; then
# Fail if doc job didn't succeed (covers cancelled, failure, skipped, or any unexpected state)
Copy link
Collaborator

@kkraus14 kkraus14 Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent the [no-ci] support from working properly as that intentionally skips the jobs and that's not a failure that should prevent merging.

Copy link
Collaborator Author

@rwgk rwgk Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, of course, it's right there in the comment 🤦‍♂️, I missed it before. Thanks!

So it'd would have to be result != 'success' && result != 'skipped', and it will not matter unless github adds a new state. Seems unlikely, I don't want to waste CI time on this subtle change.

if ${{ needs.doc.result != 'success' }}; then
exit 1
fi
if [[ "${doc_only}" != "true" ]]; then
if ${{ needs.test-linux-64.result == 'cancelled' ||
needs.test-linux-64.result == 'failure' ||
needs.test-linux-aarch64.result == 'cancelled' ||
needs.test-linux-aarch64.result == 'failure' ||
needs.test-windows.result == 'cancelled' ||
needs.test-windows.result == 'failure' }}; then
# Fail if any test job didn't succeed (covers cancelled, failure, skipped, or any unexpected state)
# When doc_only != "true", test jobs should have run, so any non-success state is a failure
if ${{ needs.test-linux-64.result != 'success' ||
needs.test-linux-aarch64.result != 'success' ||
needs.test-windows.result != 'success' }}; then
exit 1
fi
fi
Expand Down