[WIP-DO NOT REVIEW] Unconditional diffusion training example #1284
Conversation
No tests fixed yet.
phsyicsnemo.utils, launch.config is just gone. It was empty.
|
Skipped: This PR changes more files than the configured file change limit: ( |
Resolve circular import + fix linting errors.
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
…thub.com/CharlelieLrt/modulus into unconditional-diffusion-training-example
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
|
|
||
| Every import from a third-party package must fall into one of two categories: | ||
|
|
||
| 1. **Hard dependency.** The package is part of the mandatory dependency group |
There was a problem hiding this comment.
Typically, I leave numbered lists for things that have to happen in a particular order. Choice is up to you if you want to change these to bullets or not.
It certainly isn't wrong. The stylistic queue of bullets vs. numbers is just to make skimming of tech docs easier for the reader.
|
|
||
| ### Locally Optional Imports | ||
|
|
||
| Some dependencies simply provide accelerated code paths. In these situations, |
There was a problem hiding this comment.
Some dependencies simply provide accelerated code paths.
better as
Some dependencies provide accelerated code paths.
There was a problem hiding this comment.
Overall, fantastic. Thank you for using 'for example' instead of e.g.. Also, thank you for the use of 'such as' in parentheticals. You have made my tiny editor heart happy.
There was a problem hiding this comment.
| various variants of attention layers, `UNetBlock` (a block of a U-Net). |
There was a problem hiding this comment.
| least one release cycle), the model class can be promoted to production. It is |
There was a problem hiding this comment.
| for at least one release cycle before it can be deleted (see MOD-002c). |
There was a problem hiding this comment.
| - Use `pytest` parameterization to test at least two configurations |
There was a problem hiding this comment.
| could break reproducibility. Checking output shapes is insufficient to |
There was a problem hiding this comment.
| an internal submodule, should be avoided unless there are only a few choices (two |
There was a problem hiding this comment.
| or three maximum) for the class name. |
There was a problem hiding this comment.
| When there are more than two-three choices, the recommended practice is to pass an |
7 participants
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.