Skip to content

Comments

Improve production release - manual deploy & display tag#951

Open
rchlfryn wants to merge 4 commits intomainfrom
prod-release-tag
Open

Improve production release - manual deploy & display tag#951
rchlfryn wants to merge 4 commits intomainfrom
prod-release-tag

Conversation

@rchlfryn
Copy link
Collaborator

@rchlfryn rchlfryn commented Feb 18, 2026

Description

Update the production GHA workflow to trigger on version tag pushes (v*) instead of branch pushes, so workflow runs display as "Deploy v1.8.0" instead of "Merge pull request #943...".

Related Issues

Just from chatting with @busbyk

Key Changes

  • Tag-based trigger: Changed on: push: branches: ['release'] to on: push: tags: ['v*'] — deploys now trigger from the tag push in the existing release process
  • Run name: Added run-name: 'Deploy ${{ github.ref_name }}' for clear version labeling in the Actions UI
  • Release branch verification: Added a check that fails the workflow if the tag commit doesn't match the release branch, catching cases where someone pushes a tag without pushing the branch
  • Manual deploy fix: github.event.pusher.name is empty on workflow_dispatch — added || github.actor fallback to prevent Vercel meta validation error
  • Cleanup step: Hardcoded branch="release" since the deploy meta already hardcodes githubCommitRef=release and deriving it from github.event.ref breaks with tag triggers

How to test

  1. Create a tag and push both tag and branch: git tag -s v1.8.1-test -m 'v1.8.1-test' && git push origin --tags && git push origin
  2. Verify the production workflow triggers and the run shows "Deploy v1.8.1-test"
  3. Verify the "Verify release branch is up to date" step passes
  4. Trigger a manual workflow_dispatch and verify it no longer fails on the author meta

branches:
- 'release'
tags:
- 'v*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to make it something avyweb-v?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags are already scoped to the repo, so there's no risk of collision with other projects. v* is the standard semver convention (e.g., used by GitHub's own "Generate release notes" feature and most actions like actions/checkout@v4).

@github-actions
Copy link

Preview deployment: https://prod-release-tag.preview.avy-fx.org

@rchlfryn rchlfryn requested review from busbyk and yuliadub February 18, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants