Generic embeds failing on chromium - switch to blob#952
Draft
Generic embeds failing on chromium - switch to blob#952
Conversation
|
Preview deployment: https://embed-donate.preview.avy-fx.org |
…execute a static <script> tag from parsed HTML
0bab9bc to
bfe8b17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix embedded scripts (e.g., Donorbox donation form) not loading after client-side navigation on Chromium browsers. Chromium does not re-execute scripts in
srcDoc(about:srcdoc) iframes when the iframe is recreated during SPA navigation. Switching to blob URLs forces a real document navigation, ensuring scripts execute fresh every time.Related Issues
#816
Key Changes
srcDocwithsrc={blobUrl}on the GenericEmbed iframeURL.createObjectURL, revoked on unmountHow to test