GetEverything call failed if domains list used for filtering#2
Open
OlegRa wants to merge 3 commits intoNews-API-gh:masterfrom
Open
GetEverything call failed if domains list used for filtering#2OlegRa wants to merge 3 commits intoNews-API-gh:masterfrom
OlegRa wants to merge 3 commits intoNews-API-gh:masterfrom
Conversation
EverythingRequest fields applied incorrectly inside GetEverythingAsync method. Sources list used for populating domains list. This problem affect both sources- and domain-based filters.
|
After almost 1 year, no fix yet. |
Author
You can build binaries with fix from my fork or push News API guys to accept this PR if you have subscription. I did this fix for one of my client and have no mood for forcing this PR acceptance. |
joviledog
approved these changes
Dec 14, 2019
joviledog
left a comment
joviledog
left a comment
There was a problem hiding this comment.
I need to get the domains fixed too.
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 10.0.3 to 13.0.1. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@10.0.3...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
….Json-13.0.1 Bump Newtonsoft.Json from 10.0.3 to 13.0.1 in /NewsAPI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EverythingRequest fields applied incorrectly inside GetEverythingAsync method. Sources list used for populating domains list. This problem affects both sources- and domain-based filters.