ErrorInfo: add noIndent; builtins.warn: do not indent message when starting with a newline #14794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, multi-line warning messages were badly formatted due to added spaces to align with the "evaluation warning: " prefix. Now, if a warning message starts with a newline, indentation is skipped.
yunfachi
force-pushed
the
feat/builtins-warn-noIndent
branch
from
8c7374a to
cacb623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Multi-line warnings currently get extra spaces to align with the "evaluation warning: " prefix. However, sometimes it's necessary to display a large multi-line warning with custom formatting, and this padding is unnecessary. I think if a warning starts with a new line, it makes sense not to add padding to it.
Context
Before/After
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.