Added new functions to LAN8670 Driver #360
Draft
+111
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds three new functions to the LAN8670 driver API to support PLCA (Physical Layer Collision Avoidance) configuration and debugging: status checking, and TOTMR (Transmit Opportunity Timer) reading/writing capabilities.
Changes:
- Removed
__attribute__((unused))frommmd_read_register_fieldto enable its use in new functions - Added three new PLCA-related functions:
LAN8670_PLCA_Get_Status,LAN8670_PLCA_ReadTOTMR, andLAN8670_PLCA_WriteTOTMR - Added include for
u_tx_debug.hto support error logging
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| general/src/lan8670.c | Implements three new PLCA functions and enables previously unused helper function |
| general/include/lan8670.h | Declares the three new PLCA functions with documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new functions to the LAN8670 driver API, to assist with configuring and debugging PLCA.