Feature/rules dashboard #3906
Open
Feature/rules dashboard #3906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf6ef93. # Conflicts: # src/backend/src/prisma/schema.prisma # src/backend/src/services/reimbursement-requests.services.ts # src/backend/src/utils/slack.utils.ts # src/backend/tests/unmocked/reimbursement-requests.test.ts # src/frontend/src/hooks/finance.hooks.ts # src/frontend/src/pages/AdminToolsPage/FinanceConfig/IndexCodesTable.tsx # src/frontend/src/pages/FinancePage/ReimbursementRequestDetailPage/ReimbursementRequestDetailsView.tsx # src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx # src/frontend/src/tests/pages/ChangeRequestDetailPage/ChangeRequestDetailsView.test.tsx # src/frontend/src/tests/pages/ChangeRequestDetailPage/ProposedSolutionsList.test.tsx # src/frontend/src/tests/pages/CreateChangeRequestPage/CreateProposedSolutionsList.test.tsx # src/frontend/src/tests/pages/WorkPackageDetailPage/WorkPackageViewContainer/WorkPackageViewContainer.test.tsx # src/shared/src/types/task-types.ts # yarn.lock
check for organization, retrieve deleted sub-rules, throw error for no parent rule, deleted parent rule, and different organization
caused due to satisfying linting
…rules-with-no-tea #3747 get rules with no team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Finished rules system with various pages for rulesets, rules, team views, and parsing for competition rules.
Notes
Thank you to all the developers who worked on this project!
Screenshots
Will add later
To Do
Done!
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes # (issue #)