update session.fromMap() to not throw when passed a session with "sessionId": null#98
Open
eth0fox wants to merge 1 commit intoNutcake:mainfrom
Open
update session.fromMap() to not throw when passed a session with "sessionId": null#98eth0fox wants to merge 1 commit intoNutcake:mainfrom
"sessionId": null#98eth0fox wants to merge 1 commit intoNutcake:mainfrom
Conversation
Owner
|
This would fix the linked issue but has the potential to cause problems in other places where an empty session id is not expected (Example: Tapping on the session invite will open the session view, which uses the session ID to refresh the displayed data and would error out if the session id is an empty string). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97