Skip to content

update session.fromMap() to not throw when passed a session with "sessionId": null#98

Open
eth0fox wants to merge 1 commit intoNutcake:mainfrom
eth0fox:patch-1
Open

update session.fromMap() to not throw when passed a session with "sessionId": null#98
eth0fox wants to merge 1 commit intoNutcake:mainfrom
eth0fox:patch-1

Conversation

@eth0fox
Copy link
Contributor

@eth0fox eth0fox commented Feb 8, 2026

Fixes #97

@Nutcake
Copy link
Owner

Nutcake commented Feb 8, 2026

This would fix the linked issue but has the potential to cause problems in other places where an empty session id is not expected (Example: Tapping on the session invite will open the session view, which uses the session ID to refresh the displayed data and would error out if the session id is an empty string).
If sessionId is a nullable string in SkyFrosts data-model then we should adjust our local model accordingly and change usages of sessionId to handle the case of null explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid session invites render as 100,000 pixels width & height

2 participants