Skip to content

Conversation

@MarekSuchanek
Copy link
Member

  1. Referring to figures via raw-GitHub URL is causing way too often build/deploy to fail ending up with 429 Too Many Requests (for example this run had to be manually restarted 3 times). It could also cause issues if the file in target repo is changed, deleted, or renamed. The most safe way is to simply have the files locally and update when needed together with the content (which should be done anyway).
  2. One figure used .. image:: directive inconsistently with others that use .. figure::.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation to avoid using GitHub-hosted/raw URLs for embedded figures (mitigating intermittent 429/rate-limit build failures) and standardizes one diagram include to use .. figure::.

Changes:

  • Added the RDA DMP Common Standard v1.2 diagram image to the repo and updated the DMP Common Standard doc to reference it locally.
  • Updated the FAIR Test Results Vocabulary doc to use a local figure and switched from .. image:: to .. figure::.
  • Reduced reliance on external GitHub-hosted assets by pointing figure directives at checked-in files.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
docs/commons/dmp/maDMP-diagram-v1.2.png Adds the diagram asset to be referenced locally instead of via raw GitHub URLs.
docs/commons/dmp/dmp-common-standard.rst Updates the figure directive to use the new local PNG file.
docs/commons/FAIR/FAIR-Test-Results-Vocabulary-FTR.rst Switches to .. figure:: and references the local diagram image instead of a GitHub-hosted URL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants