Skip to content

Conversation

@sirisudheeksha
Copy link
Contributor

Description

Lesson List “Filter” change is not updating results. Changing options like “This Year/Month/Week” left the list unchanged or inconsistent. This PR ensures filter changes update state, refresh the dataset and resolves minor tag removal issues.

Related PRS (if any):

#3107

Main changes explained:

  • Update file LessonListForm.jsx:
  • Sync filter/sort/tags with URL query for reload/shareable state.
  • Add loading indicator and empty-result message.
  • Ensure filter change triggers re-computation.
  • Fix tag removal to remove by value reliably.
  • Update file LessonCard.jsx:
  • Safe HTML parsing using optional chaining to prevent errors.
  • Update file Lessons.jsx:
  • Minor cleanup to deletion handler; keeps filtered list consistent after delete.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache!!!
  4. log in as admin user
  5. go to http://localhost:3000/bmdashboard/lessonlist
  6. Verify Change Filter (This Year/Month/Week): list refreshes; loading appears briefly; results reflect selection.
  7. Add/remove Tags: removing tags updates results.
  8. Change Sort: order updates; Filter selection remains.
  9. Reload the page: filter/sort/tags restored from URL.
  10. When no results: “No lessons match this filter.” shown.

Screenshots or videos of changes:

Screenshot 2026-01-10 at 7 42 45 PM Screenshot 2026-01-10 at 7 42 54 PM Screenshot 2026-01-10 at 8 06 42 PM Screenshot 2026-01-10 at 8 07 22 PM

@netlify
Copy link

netlify bot commented Jan 11, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 6504d72
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6963265bf47ddc0008e14006
😎 Deploy Preview https://deploy-preview-4698--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants