-
Notifications
You must be signed in to change notification settings - Fork 58
A11y Bug 7396207: Add screen reader direction announcements for Region mode keyboard navigation #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y Bug 7396207: Add screen reader direction announcements for Region mode keyboard navigation #600
Conversation
Co-authored-by: dewanymca <15336470+dewanymca@users.noreply.github.com>
Co-authored-by: dewanymca <15336470+dewanymca@users.noreply.github.com>
|
@copilot This is not what was required. Whenever, we start narrator and try to clip in "Region" mode using arrow keys, the arrow key does not work with the Narrator on. Expected outcome: Make the arrow key clipping work in region mode when using Narrator and also narrator announce Up, Down, Left or right |
You're absolutely right - I misunderstood the issue. The problem is with Region mode clipping using arrow keys when Narrator is running, not the Location menu. I'll fix the Region selector to properly work with screen readers by adding aria-live announcements for cursor movements and selection state. |
Co-authored-by: aanchalbhansali <185747873+aanchalbhansali@users.noreply.github.com>
…riate priorities Co-authored-by: aanchalbhansali <185747873+aanchalbhansali@users.noreply.github.com>
|
@copilot Just keep the direction announcements for now and remove all the changes including package.json |
… messages Co-authored-by: aanchalbhansali <185747873+aanchalbhansali@users.noreply.github.com>
…NoteDev/WebClipper into copilot/fix-onenote-clipper-issue
|
@copilot remove the changes from package-lock.json file |
Co-authored-by: aanchalbhansali <185747873+aanchalbhansali@users.noreply.github.com>
Add screen reader direction announcements for Region mode keyboard navigation
Problem
When using Narrator or other screen readers in Region mode, arrow keys work but don't announce cursor movements, preventing users with no vision from effectively selecting regions.
Changes Made
Screen reader support for Region mode:
aria-live="polite"region for direction announcementsImplementation:
ariaLiveMessagetoRegionSelectorStatelastAnnouncementTimeandannouncementThrottleMsannounceAriaLiveMessage()method for throttled direction announcementsgetDirectionMessage()to translate key presses to direction nameskeyDownHandlerLocalization strings added:
WebClipper.Accessibility.ScreenReader.Up: "Up"WebClipper.Accessibility.ScreenReader.Down: "Down"WebClipper.Accessibility.ScreenReader.Left: "Left"WebClipper.Accessibility.ScreenReader.Right: "Right"How It Works
The Region selector already has functional arrow key handlers. This adds screen reader support:
This allows users with no vision to understand cursor movement direction while using Region mode with Narrator, meeting MAS 4.3.1 accessibility requirements.
Testing
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.