Skip to content

Conversation

@josephjclark
Copy link
Collaborator

@josephjclark josephjclark commented Jan 23, 2026

To better align version hashing between lightning and CLI, I've made some changes

  • lowercase step names
  • remove keys from the hash string

These are not breaking

Closes #4346

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@github-project-automation github-project-automation bot moved this to New Issues in v2 Jan 23, 2026
@josephjclark josephjclark marked this pull request as draft January 23, 2026 17:25
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.32%. Comparing base (549de66) to head (33e58de).

Files with missing lines Patch % Lines
lib/lightning/workflow_versions.ex 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4349      +/-   ##
==========================================
+ Coverage   89.29%   89.32%   +0.02%     
==========================================
  Files         425      425              
  Lines       19994    19997       +3     
==========================================
+ Hits        17854    17862       +8     
+ Misses       2140     2135       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

Version hashing: possible changes?

2 participants