[ WIP ] Add tutorial for membrane RBFE calculation#286
Open
hannahbaumann wants to merge 2 commits intomainfrom
Open
[ WIP ] Add tutorial for membrane RBFE calculation#286hannahbaumann wants to merge 2 commits intomainfrom
hannahbaumann wants to merge 2 commits intomainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
hannahbaumann
changed the title
jthorton
reviewed
Feb 6, 2026
| @@ -0,0 +1,1153 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Line #25. settings=RelativeHybridTopologyProtocol._adaptive_settings(
Do we not need to add the lipid force field to the settings or is adaptive doing this? Also this is another place we are exposing _adaptive to the world do we need to add a public entry point?
Reply via ReviewNB
| @@ -0,0 +1,1153 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Line #43. network = openfe.AlchemicalNetwork(transformations)
Woow so many warnings we need to remove a lot of these!
Reply via ReviewNB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.