Conversation
|
No API break detected ✅ |
|
@IAlibay let me know if you have any feedback, I think pulling down the benchmark repo or using a local copy would be a nice improvement. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 92.79% 92.74% -0.06%
==========================================
Files 141 141
Lines 10863 10868 +5
==========================================
- Hits 10080 10079 -1
- Misses 783 789 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🤔 This might be worth discussing, I'm wondering if this is the right place for this to exist. Ideally we would want to have this in a place where we can also store results. We still need to clean up openfe-benchmarks, but maybe there? To explain what I'm thinking a bit more, I can see this becoming a thing that grows to be more automated over time, especially if you do things like pulling down the benchmark repo automatically etc... and so maybe it should be somewhere we can test it etc.. |
|
I agree, I think it needs to live somewhere, my thoughts putting it here is it isn't shipped with the package and isn't in a very public place, I worry about putting it in the benchmark repo right now since it doesn't have a ton of visibility, I do think it should get tested, happy to put it somewhere else! |
First pass on a script to QA using our
RelativeHybridTopologyProtocolChecklist
newsentryDevelopers certificate of origin