Skip to content

add --download-only option to openfe test#1814

Open
atravitz wants to merge 16 commits intomainfrom
cli/add_fetch_test_data
Open

add --download-only option to openfe test#1814
atravitz wants to merge 16 commits intomainfrom
cli/add_fetch_test_data

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 28, 2026

this will allow us to:

  • pull all the test data up-front, so that we fail fast if there's a zenodo-fetching issue
  • enable users to pull data on a instance with internet access, then run tests on air-gapped compute
  • both cli and openfe zenodo info is stored in a registry - this should make it easier to migrate to cloudflare in the future, plus we can maybe diff that file to trigger a cache update for CI

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 82.19178% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.98%. Comparing base (c09629e) to head (6fb3a78).

Files with missing lines Patch % Lines
src/openfe/data/_downloader.py 25.00% 9 Missing ⚠️
src/openfecli/commands/test.py 70.00% 3 Missing ⚠️
src/openfe/tests/protocols/conftest.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   95.27%   92.98%   -2.30%     
==========================================
  Files         201      204       +3     
  Lines       17580    17623      +43     
==========================================
- Hits        16750    16386     -364     
- Misses        830     1237     +407     
Flag Coverage Δ
fast-tests 92.98% <82.19%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz requested a review from mikemhenry January 28, 2026 18:10
@atravitz atravitz force-pushed the cli/add_fetch_test_data branch from 4f569df to 86316d4 Compare January 29, 2026 18:10
@atravitz atravitz force-pushed the cli/add_fetch_test_data branch from 86316d4 to 28f2869 Compare January 29, 2026 18:20
return universe


RFE_OUTPUT = pooch.create(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we moved to from figshare to zenodo here:

RFE_OUTPUT = pooch.create(
path=POOCH_CACHE,

but this was left as a stragger no-op.

@atravitz atravitz marked this pull request as ready for review February 6, 2026 20:39
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

🚨 API breaking changes detected! 🚨
View logs for this step

@atravitz atravitz changed the title add download-only option to openfe test add --download-only option to openfe test Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant