Clean for gate9.4.2 #747
Open
Clean for gate9.4.2 #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
included new parameters for filtering based on the maximum z-position difference and sector distance (s) between two events.
… invalid coincidences. - Implemented a new condition to check the difference in Z to reject coincidences. - Rejected coincidences if they do not meet the distance and angle criteria
… invalid coincidences. - Implemented a new condition to check the difference in Z to reject coincidences. - Rejected coincidences if they do not meet the distance and angle criteria
…etizer.cc and GateDiscretizer.hh
…ed in DiscretizerModule
…ummy python script for macro_conversion
…and adding macro generator flag
Documentation of "Confinement with truncated Gaussian distribution" and "Spatial resolution with 1 and 2 dimensional distributions".
Change element->GetNumberOfElements() to element->GetNumberOfIsotopes() @narbor
…rMgr to ensure memory cleanup
…incidence sorters called "Coincidences" to avoid ambiguity issues
…th multiple layers and/or multiple scanners.
- Add delete statements for digits that are not stored in geant gigit storage - Convert GateVolumeID from std::vector inheritance to composition
Inheritance from std::vector is considered as a bad bractice because std::vector lacks a virtual destructor. Implement GateVolumeID as a thin wrapper over std::vector using composition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.