Fix bug where radius, blur, and max were not being used when passed i…#21
Merged
jeremiahrhall merged 2 commits intoOpenGov:masterfrom Oct 19, 2017
Merged
Conversation
jeremiahrhall
requested changes
Oct 16, 2017
Member
jeremiahrhall
left a comment
jeremiahrhall
left a comment
There was a problem hiding this comment.
One request in the example. Otherwise the code looks good. I'll give it a spin after your next update and hopefully get this merged. Thanks for this 👍
| this.setState({ addressPoints: addressPoints.slice(500, 1000) }); | ||
| }, 5000); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This was here to test the behavior of refocusing/zooming the map when the points change. Can you maybe add a separate control to toggle between two sets of data or put this back?
Contributor
Author
|
Updated to include a toggle to limit the data points within the example. |
jeremiahrhall
approved these changes
Oct 19, 2017
Member
|
@fcwheat Thank you for your patience and for your work. This is great! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n as props. Fixes issue #17.
Additionally, I updated the example file to include sliders for modifying the radius, blur, and max value. This gives users the ability to see how updating these values impacts the heatmap.