set size on Map to prevent Failed to execute getImageData error#27
Open
jefffriesen wants to merge 3 commits intoOpenGov:masterfrom
Open
set size on Map to prevent Failed to execute getImageData error#27jefffriesen wants to merge 3 commits intoOpenGov:masterfrom
jefffriesen wants to merge 3 commits intoOpenGov:masterfrom
Conversation
Member
|
Hi @jefffriesen. This looks good but, can you remove the |
|
Seem like this PR is dead but I would really like to have #14 fixed. @jefffriesen @jeremiahrhall maybe I can recreate the PR if you guys are too busy? |
Member
|
Hi @Tomekmularczyk, If you push up a PR I'll review it. :) |
|
@jeremiahrhall deal :) |
|
as I mentioned in #31 simply setting width and height doesn't solve the issue #14 - at least for me. Sory for the fuss. |
Author
|
Sorry this slipped off my todo list. If you can submit or fix the PR go for it
… On Jun 8, 2018, at 12:39 PM, Tomek ***@***.***> wrote:
as I mentioned in #31 simply setting with and height doesn't solve the issue #14 - at least for me. Sory for the fuss.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a PR in simpleheat.js that this library depends on that hasn't been accepted yet: https://github.com/mourner/simpleheat/pull/34/files
There is another issue filed in this library that suggests a patch to the simpleheat.js that's pulled down with this library. That approach is fragile and can break in the future. https://github.com/OpenGov/react-leaflet-heatmap-layer/issues/14
Adding height and width on the component fixes this problem so I'm including it in the documentation.