General improvements, better Linux support, a few more formats, Godot integration#1096
Draft
Frozenreflex wants to merge 19 commits intoOpenKH:masterfrom
Draft
General improvements, better Linux support, a few more formats, Godot integration#1096Frozenreflex wants to merge 19 commits intoOpenKH:masterfrom
Frozenreflex wants to merge 19 commits intoOpenKH:masterfrom
Conversation
….Drawing for better Linux compatibility, cleanup
Frozenreflex
changed the title
… start abstracting skeleton and animation data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, as I am still working on stuff
I'm on Linux, using OpenKH as a library in Godot, and these are the modifications and improvements I've made.
Better Linux support
While System.Drawing is usable on Linux in .NET 6 using libgdiplus, it's deprecated, and in 7 and onwards it's completely non-functional (thanks microsoft) and throws when you try to use it. As a patchwork fix, I replaced it with IronDrawing, but in the future I'd like to replace it with something else.
I also removed the extraneous Windows stuff attached to the KH1 library.
CVBL
Implementation based on the CVBL Converter python scripts in the openkh discord server
Better SCD implementation
Functional SCD implementation based on KHPCSoundTools,
StreamFilescontains the raw encrypted stream, whileMediaFilescontains the real media file. Tested using KH2 Sora's battle voice lines, with values fromMediaFilesbeing piped into Godot'sAudioStreamOggVorbis.LoadFromBuffermethod