fix: don't call batch() if batch == False#417
Open
MikeWalrus wants to merge 4 commits intoOpenMined:mainfrom
Open
fix: don't call batch() if batch == False#417MikeWalrus wants to merge 4 commits intoOpenMined:mainfrom
MikeWalrus wants to merge 4 commits intoOpenMined:mainfrom
Conversation
Member
|
Thank you for the contribution! Can you please add a test that was failing before, and it is working with your fix? Thanks! |
Author
|
Haven't got the time to look at the testing code yet. I'll try to add the test someday. |
Member
Thanks! A Python test is enough to cover the fix, and to justify it in the future. |
|
hello, i wonder is there any other plain_modulus that can be used in BFV? I find only 1032191 and 786433 can worked other wise will cause the error: ValueError: encryption parameters are not valid for batching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, creating a CKKSTensor from a PyTorch scalar throws an exception even with
batch=False.This pr fixes it by not calling
TensorStorage::batchifbatch==false.Affected Dependencies
None.
How has this been tested?
Checklist