Skip to content

Fix heap-buffer-overflow in GeorefMetadataLayerDescriptor #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oliverchang wants to merge 1 commit into from
Closed

Fix heap-buffer-overflow in GeorefMetadataLayerDescriptor #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion api/bag_georefmetadatalayerdescriptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,13 @@ std::shared_ptr<GeorefMetadataLayerDescriptor> GeorefMetadataLayerDescriptor::op
hsize_t numFields = 0;
fileDataSpace.getSimpleExtentDims(&numFields, nullptr);

const auto attrDataType = attribute.getDataType();
if (attribute.getStorageSize() != numFields * attrDataType.getSize())
throw InvalidValueSize{};
Copy link
Collaborator

@selimnairb selimnairb Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use curly braces, even for a single-line if statement, or place on a single line (yes, I know, other parts of the codebase don't do this, but I want to make sure new code does).


RecordDefinition definition(numFields);

attribute.read(attribute.getDataType(), definition.data());
attribute.read(attrDataType, definition.data());

// Determine chunk size and compression level.
const auto chunkSize = BAG::getChunkSize(h5file, internalPath);
Expand Down
Loading