Conversation
53492c9 to
0ddec40
Compare
0ddec40 to
f4d5dec
Compare
7layermagik
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This undoes the account prefetcher, which really implemented prefetch and async storage at the same time in the account loader, in favor of implementing just async storage in accounts DB.
testing
I crossed two epoch boundaries 3 times each with no incident:
I also ctrl C'd/resumed replay a few times.
performance
I ran this on f4d5dec and c48e6d3 (dev before prefetcher):
The slot replay duration improvement is more modest, only ~10ms. Probably due to LoadBlockAccounts still being on critical path and added coordination. However, this design decouples prefetch and async storage. It also could evolve to keeping modified accounts in memory until a slot is committed. For example, the list could become a tree of uncommitted slot modifications, and we don't have to invoke the store worker on those modifications until we know some subtree is confirmed.