Skip to content

raidboss: initial r12s p1 triggers and timeline#1002

Open
Legends0 wants to merge 14 commits intomainfrom
r12sp1-initial-triggers-and-p1-p2-timeline
Open

raidboss: initial r12s p1 triggers and timeline#1002
Legends0 wants to merge 14 commits intomainfrom
r12sp1-initial-triggers-and-p1-p2-timeline

Conversation

@Legends0
Copy link
Collaborator

@Legends0 Legends0 commented Feb 8, 2026

Breaking apart p1 from p2 in #964.

I've left in some aoe/spread/tankbuster and a couple gainsEffects based triggers for p2 and full timeline.

Some ideas of TODOs for P1:

  • Mortal Coil calls
  • Split Scourge/Venomous Scourge add additional trigger for avoid heads, bait heads for tanks/non-tanks (I can probably add something quickly based on the Split Scourge hit for a followup)
  • Find safe spots for Curtain Call Unbreakable Flesh
  • Find safe spots for Slaughtershed Stack/Spreads

@Legends0 Legends0 requested review from valarnin and xiashtra February 8, 2026 22:10
@Legends0 Legends0 mentioned this pull request Feb 8, 2026
22 tasks
@xiashtra
Copy link
Collaborator

There are still phase 2 triggers mixed in with this.

@Legends0
Copy link
Collaborator Author

There are still phase 2 triggers mixed in with this.

I am not sure if the concern is specifically the title not mentioning the p2 triggers or that all triggers should be removed. I have removed them. My thought process was it would not hurt to leave in the spell, headmarker, gainseEffect id matching triggers and leave the phase tracking triggers in.

@xiashtra
Copy link
Collaborator

There are still phase 2 triggers mixed in with this.

I am not sure if the concern is specifically the title not mentioning the p2 triggers or that all triggers should be removed. I have removed them. My thought process was it would not hurt to leave in the spell, headmarker, gainseEffect id matching triggers and leave the phase tracking triggers in.

There was Idyllic Dream triggers still in place. It defeats the purpose of separating phase 1 to get it reviewed faster if there's still triggers for deep into phase 2 that would have to get checked also. Same for the timeline.

@Legends0 Legends0 changed the title raidboss: initial r12s p1 triggers and p1/p2 timeline raidboss: initial r12s p1 triggers and timeline Feb 11, 2026
@Legends0
Copy link
Collaborator Author

There was Idyllic Dream triggers still in place. It defeats the purpose of separating phase 1 to get it reviewed faster if there's still triggers for deep into phase 2 that would have to get checked also. Same for the timeline.

I have left the addCombatant jump in plus the first aoe to prevent it from being an issue in p2.

Also comment about what it is they do differently
This happens if for instance a player disconnects. Does over a million damage to the party.
@Legends0 Legends0 closed this Feb 14, 2026
@Legends0 Legends0 deleted the r12sp1-initial-triggers-and-p1-p2-timeline branch February 14, 2026 17:02
@Legends0 Legends0 restored the r12sp1-initial-triggers-and-p1-p2-timeline branch February 14, 2026 17:03
@Legends0 Legends0 deleted the r12sp1-initial-triggers-and-p1-p2-timeline branch February 14, 2026 17:05
@Legends0 Legends0 restored the r12sp1-initial-triggers-and-p1-p2-timeline branch February 14, 2026 17:09
@Legends0 Legends0 reopened this Feb 14, 2026
@github-actions github-actions bot removed the needs-review Awaiting review label Feb 16, 2026
Co-authored-by: Dowon <ks2515@naver.com>
@github-actions github-actions bot added the needs-review Awaiting review label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants