Skip to content

raidboss: fix user triggerset order #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Souma-Sumire wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −15
Open

raidboss: fix user triggerset order #993

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd1ea82
Update popup-text.ts
Souma-Sumire Feb 4, 2026
76264be
Update popup-text.ts
Souma-Sumire Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions ui/raidboss/popup-text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,23 +704,26 @@ export class PopupText {
this.triggerSets.push(...this.options.Triggers);

// Eliminate any trigger sets with duplicate ids, allowing later ones to override earlier ones.
const uniqueById = new Map<string, typeof this.triggerSets[number]>();
const noIdList: typeof this.triggerSets = [];
for (const triggerSet of this.triggerSets) {
if (triggerSet.id === undefined) {
noIdList.push(triggerSet);
continue;
}
const existing = uniqueById.get(triggerSet.id);
if (existing !== undefined) {
console.log(
`Overriding trigger set id '${triggerSet.id}' from '${existing.filename}' with '${triggerSet.filename}'`,
);
// Filter the list to keep the last instance of each ID while preserving order.
const lastVersionOfId = new Map<string, typeof this.triggerSets[number]>();
for (const set of this.triggerSets) {
if (set.id !== undefined) {
const existing = lastVersionOfId.get(set.id);
if (existing !== undefined) {
console.log(
`Overriding trigger set id '${set.id}' from '${existing.filename}' with '${set.filename}'`,
);
}
lastVersionOfId.set(set.id, set);
}
uniqueById.set(triggerSet.id, triggerSet);
}
this.triggerSets = [...noIdList, ...uniqueById.values()];
this.triggerSetsById = Object.fromEntries(uniqueById);

this.triggerSets = this.triggerSets.filter((set) => {
if (set.id === undefined)
return true;
return lastVersionOfId.get(set.id) === set;
});
this.triggerSetsById = Object.fromEntries(lastVersionOfId);
}

OnChangeZone(e: EventResponses['ChangeZone']): void {
Expand Down