Added channel_url option to set splitter address and port from channel description#22
Open
Glitchfix wants to merge 5 commits intoP2PSP:masterfrom
Open
Added channel_url option to set splitter address and port from channel description#22Glitchfix wants to merge 5 commits intoP2PSP:masterfrom
Glitchfix wants to merge 5 commits intoP2PSP:masterfrom
Conversation
Glitchfix
changed the title
channel_url default value problem resolved
Accidentally deleted line caused peer and monitor binaries to crash
The splitter address and port should not be assigned default value when channel_url is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21