Skip to content

fix python api compat issues #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BingooYang merged 2 commits into from
Feb 4, 2026
Merged

fix python api compat issues #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87edc8c
fix python api compat issues
BingooYang Feb 4, 2026
c8d31bd
Update cuda_ipc.py
BingooYang Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flashinfer/comm/cuda_ipc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def create_shared_buffer(
pointer = cudart.cudaMalloc(size_in_bytes)
handle = cudart.cudaIpcGetMemHandle(pointer)
if group is None:
group = dist.group.WORLD
group = dist.get_group()
# world_size = dist.get_world_size(group=group)
rank = dist.get_rank(group=group)
# handles = [None] * world_size
Expand Down
19 changes: 16 additions & 3 deletions flashinfer/comm/trtllm_ar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,9 +767,22 @@ def trtllm_custom_all_reduce(
def _should_use_oneshot(
token_num: int, hidden_dim: int, dtype: torch.dtype, world_size: int
) -> bool:
comm_size_mb = (
token_num * hidden_dim * 2 * world_size * dtype.itemsize / 1024 / 1024
)
DTYPE_SIZE_MAP = {
torch.float16: 2,
torch.bfloat16: 2,
torch.float32: 4,
torch.float64: 8,
torch.int8: 1,
torch.int16: 2,
torch.int32: 4,
torch.int64: 8,
torch.uint8: 1,
torch.bool: 1,
torch.complex64: 8,
torch.complex128: 16,
}
itemsize = DTYPE_SIZE_MAP[dtype]
comm_size_mb = token_num * hidden_dim * 2 * world_size * itemsize / 1024 / 1024
return comm_size_mb <= _use_oneshot_heuristics[world_size]


Expand Down