Open
Conversation
but it doesn't work yet
khozzy
reviewed
Nov 7, 2018
| knowledge_array = {i: 0.0 for i in range(all_actions)} | ||
|
|
||
| cll.sort(key=lambda cl: cl.action) | ||
| cll.sort(key=lambda cl: cl.action if isinstance(cl.action, int) else -1) |
Member
There was a problem hiding this comment.
What causes that error?
It's a hack, but does not solve the cause of the problem
Contributor
Author
There was a problem hiding this comment.
It only happens when actions are None, but I don't know the cause of this.
Contributor
Author
There was a problem hiding this comment.
Even with this hack, there are sometimes other errors caused by action being None, so I guess this hack doesn't even solve the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is allowed for actions to be None, which sometimes can give errors while sorting them. This quick fix solves this issue giving the value of "-1" to actions which are not an int.
